Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support parameter substitution for resolver params #5387

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Support parameter substitution for resolver params #5387

merged 1 commit into from
Aug 29, 2022

Conversation

abayer
Copy link
Contributor

@abayer abayer commented Aug 27, 2022

Changes

Part of #4710

Until we do v1beta1 of ResolutionRequest, it will still have parameters of map[string]string, so we're only doing limited substitution.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@abayer abayer added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 27, 2022
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Aug 27, 2022
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 27, 2022
@abayer
Copy link
Contributor Author

abayer commented Aug 27, 2022

/assign @lbernick @jerop @vdemeester @dibyom

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/apply.go 98.8% 97.8% -1.0
pkg/reconciler/pipelinerun/resources/pipelineref.go 85.7% 89.2% 3.5
pkg/reconciler/taskrun/resources/apply.go 99.3% 99.3% 0.0
pkg/reconciler/taskrun/resources/taskref.go 83.0% 85.2% 2.2

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2022
@lbernick
Copy link
Member

I'm a bit confused-- we're allowing substitution of array and object params in resolver ref, but when they're passed to the resolution request we can only do string params? it seems like it would make more sense to not allow array and object params in resolver ref if we can't pass them to resolution request.

@abayer
Copy link
Contributor Author

abayer commented Aug 29, 2022

Yeah, I'm planning to add support for array/object params to ResolutionRequest in v1beta1, so I debated whether to block them for now or just shrug and only pass on strings. I opted for the latter, since it's fairly short term, but am willing to be persuaded. =)

@lbernick
Copy link
Member

what's the timeline for v1beta1? if v1beta1 resolutionrequest won't be in the same release I'd definitely say reject. If they'll be in the same release it would still be good for the commit to be self consistent, but I wouldn't push back as much

@abayer
Copy link
Contributor Author

abayer commented Aug 29, 2022

what's the timeline for v1beta1? if v1beta1 resolutionrequest won't be in the same release I'd definitely say reject. If they'll be in the same release it would still be good for the commit to be self consistent, but I wouldn't push back as much

So resolution will be fully merged for v0.40, but I plan to let it wait til v0.42 (in November) for v1beta1 to give it a month in the wild to make sure no critical issues pop up. I'll rework this to reject array/object params shortly.

@abayer abayer force-pushed the resolution-param-substitution branch from 419587b to 0fb9b6b Compare August 29, 2022 15:35
@abayer
Copy link
Contributor Author

abayer commented Aug 29, 2022 •
edited
Loading

@lbernick Updated!

EDIT: Whoops, gotta do v1 as well.

EDIT AGAIN: And that's done too.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/apply.go 98.8% 97.8% -1.0
pkg/reconciler/pipelinerun/resources/pipelineref.go 85.7% 89.2% 3.5
pkg/reconciler/taskrun/resources/apply.go 99.3% 99.3% 0.0
pkg/reconciler/taskrun/resources/taskref.go 83.0% 85.2% 2.2

@abayer
Support parameter substitution for resolver params
a661de5 
Part of tektoncd#4710

Until we do `v1beta1` of `ResolutionRequest`, it will still have parameters of `map[string]string`, so we're only doing limited substitution.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
@abayer abayer force-pushed the resolution-param-substitution branch from 0fb9b6b to a661de5 Compare August 29, 2022 15:43
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/apply.go 98.8% 97.8% -1.0
pkg/reconciler/pipelinerun/resources/pipelineref.go 85.7% 89.2% 3.5
pkg/reconciler/taskrun/resources/apply.go 99.3% 99.3% 0.0
pkg/reconciler/taskrun/resources/taskref.go 83.0% 85.2% 2.2

lbernick
lbernick reviewed Aug 29, 2022
View reviewed changes
Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2022
@tekton-robot tekton-robot merged commit d27c53c into tektoncd:main Aug 29, 2022
@lbernick lbernick mentioned this pull request Sep 29, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick left review comments

@vdemeester vdemeester vdemeester approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@vdemeester vdemeester

@dibyom dibyom

@jerop jerop

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@abayer @tekton-robot @lbernick @vdemeester @dibyom @jerop